Add an option to use vendored libgit2 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
reviewed
Sep 25, 2022
There was a problem hiding this comment.
Would you consider making a cargo PR to expose vendored-libgit2 as a cargo feature? That way cargo-show-asm's vendored-libgit2 feature won't just silently stop working when cargo updates git2.
|
Hmm... I would expect it to either keep working as long as they end up depending on the same foreign library or will stop compiling when it starts to depend on two of them, but yea, making a cargo request would be a better solution and not just for |
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Sep 30, 2022
Expose libgit2-sys/vendored feature as vendored-libgit2 ### What does this PR try to resolve? Compiling cargo on MacOS can be problematic due present libraries, `cargo` already supports vendoring for openssl (and it helps pacak/cargo-show-asm#51 to some users). This pull request attempts to extend vendoring support to libgit2 in order to fix more foreign library issues: pacak/cargo-show-asm#50 While it is possible for me to enable it on my side (pacak/cargo-show-asm#52) a special care needs to keep versions in sync. Exposing this feature in `cargo` directly will make such fixes for my and other crates more robust. ### How should we test and review this PR? Disabled by default means existing behavior is unchanged, testing with it enabled to confirm if it still works should do the trick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.